c++ - Best practices - returning pointer from a function -

-

i have dilemma, how should return smart pointer function, when function might fail. pick 1 of following options:

  1. return pointer, , throw exception if function fails:
      std::shared_ptr foo() {         // ...         if (!ok)           throw;         return ptr;     }
  1. return pointer, , return empty pointer, if function fails
      std::shared_ptr foo() {         // ...         if (!ok)             return std::shared_ptr();          return ptr;     }
  1. pass pointer reference, , return bool flag
      bool foo(std::shared_ptr& ptr) {         // ...         if (ok)             ptr = ...;          return ok;     }

is there best practice, guideline, how report, function didn't execute properly? or project-specific?

thanks answers

honestly correct answer depends on called function does, , consequence of failure is. libraries i'd suggest either throwing exception or returning value indicates failure. passing pointer reference , returning flag seems questionable unless you're using idiom frequently, or if there reason externally manage shared pointer.


Comments

Post a Comment

Popular posts from this blog

Django REST Framework perform_create: You cannot call `.save()` after accessing `serializer.data` -

-
i have following viewset: class artistprofileviewset(viewsets.modelviewset): queryset = artistprofile.objects.all() serializer_class = artistprofileserializer def perform_create(self, serializer): if serializer.is_valid(): serializer.save() with following serializers: class simpleartisttrackserializer(serializers.hyperlinkedmodelserializer): class meta: model = artisttrack fields = (...my fields...) class artistprofileserializer(serializers.hyperlinkedmodelserializer): owners = userserializer(many=true, required=false) tracks = simpleartisttrackserializer(many=true, required=false) class meta: model = artistprofile fields = (...my fields...) i getting following error: assertionerror: cannot call `.save()` after accessing `serializer.data`.if need access data before committing database inspect 'serializer.validated_data' instead. i don't see editing serializer.data object. th...
Read more

Why does Go error when trying to marshal this JSON? -

-
i'm trying rather simple example of trying decode json file structs using golang. however, when attempting error that json: cannot unmarshal object go value of type []main.track which don't understand. here's code in question, , json can found here . package main import ( "encoding/json" "fmt" "net/http" "os" ) // tracks group of track types type tracks struct { tracks []track } // track represents singular track type track struct { name string url string artist artist } // artist represents single artist type artist struct { name string mbid string url string } func main() { url := "http://ws.audioscrobbler.com/2.0/?method=geo.gettoptracks&api_key=c1572082105bd40d247836b5c1819623&format=json&country=netherlands" response, err := http.get(url) if err != nil { fmt.printf("%s\n", err) os.exit(1) } de...
Read more