c++ - Doubly linked list Core dump -

-

thanks in advance.

i making doubly linked list.

everything working fine, realized when added new class node somewhere in middle, left pointer still pointing @ node before (now 2 spaces away).

so added new node pointer on line 46.

then on line 51 told node point new node.

so :

  • first had new node temp off in space

  • then make pointer temp2 loop through list

  • lastly tell temp3 point node after temp2's node

after function runs, order should temp2->temp->temp3

my main point: after added line 51, program core dumps(segmentation fault) , closes out.

how can fix this? happens when add isn't taking place of head pointer.

void add(node *&head, node *&tail, node *&current) {     node *temp = new node;  //creates pointer pointing new class node     cin >> temp->letter;    // user input      current = head; // creates pointer point @ first node     while (current != null) // while list isn't empty     {         if (current->letter == temp->letter)         { // letter exists             cout << "duplicate: " << temp->letter << endl << endl;             return;         }         else         { // loop through list moving tail pointer end while checking duplicates             tail = current;             current = current->right_link;         }     }      current = temp; // current = new added node      if (isempty(head))     { // if first node         temp->left_link = null;         temp->right_link = null;         head = temp; // head ,          tail = temp; // tail both point first , node.     }     else     { // if new letter value less head value         if(temp->letter < head->letter)         {             temp->right_link = head; // node points (right) head             temp->left_link = null; // left node point nothing.             head->left_link = temp; // head (currently second node) points (left) first node             head = temp; // head pointer moves first position         }         else         { // if new node goes anywhere other head             node *temp2 = head; // new node cycle through list             while(temp2->right_link != null && temp2->right_link->letter < temp->letter)             { // if temp2 points node , node's value less temp node value                 temp2 = temp2->right_link;             }             node *temp3 = temp2->right_link;             temp->right_link = temp2->right_link; // when temp2 stops looping, temp point                                                   // same node temp2.             temp2->right_link = temp; // temp2's current node point temp, causing temp                                 // added list (after temp2)             temp3->left_link = temp; // point node (after newly inserted node) left new node             temp->left_link = temp2; // connects left pointer between temp , temp2             if(temp->right_link == null)                 tail = temp;         }     }     cout << "added : " << temp->letter << endl << endl; }

if temp2->right_link == null

 46      node *temp3 = temp2->right_link;

is null pointer, can't

 51      temp3->left_link = temp;

which should have been obvious if used debugger.


Comments

Post a Comment

Popular posts from this blog

ios - Memory not freeing up after popping viewcontroller using ARC -

-
hi project arc based, using uinavigationcontroller make transition between viewcontroller. using profiler analyse happening behind scene memory. noticed when push viewcontroller allocate memory components , when pop not freeing allocated memory. since using arc unable implement dealloc or release component. have analysed in detail , there no memory leak in project. i not using strong property push viewcontroller. here how pushing viewcontroller. viewcontroller *obj = [[viewcontroller alloc] init]; [self.navigationcontroller pushviewcontroller:obj animated:no]; any clue whats going on? should free memory have consumed. please advise your description indicates have retain cycle, leads objects not being deallocated. typical source of retain cycles properties assigned loading nib files (usually declared iboutlet ). two strategies break them , release objects: declare property weak : @property (nonatomic, weak) iboutlet uilabel *statuslabel; set property nil in...
Read more

Django REST Framework perform_create: You cannot call `.save()` after accessing `serializer.data` -

-
i have following viewset: class artistprofileviewset(viewsets.modelviewset): queryset = artistprofile.objects.all() serializer_class = artistprofileserializer def perform_create(self, serializer): if serializer.is_valid(): serializer.save() with following serializers: class simpleartisttrackserializer(serializers.hyperlinkedmodelserializer): class meta: model = artisttrack fields = (...my fields...) class artistprofileserializer(serializers.hyperlinkedmodelserializer): owners = userserializer(many=true, required=false) tracks = simpleartisttrackserializer(many=true, required=false) class meta: model = artistprofile fields = (...my fields...) i getting following error: assertionerror: cannot call `.save()` after accessing `serializer.data`.if need access data before committing database inspect 'serializer.validated_data' instead. i don't see editing serializer.data object. th...
Read more

Why does Go error when trying to marshal this JSON? -

-
i'm trying rather simple example of trying decode json file structs using golang. however, when attempting error that json: cannot unmarshal object go value of type []main.track which don't understand. here's code in question, , json can found here . package main import ( "encoding/json" "fmt" "net/http" "os" ) // tracks group of track types type tracks struct { tracks []track } // track represents singular track type track struct { name string url string artist artist } // artist represents single artist type artist struct { name string mbid string url string } func main() { url := "http://ws.audioscrobbler.com/2.0/?method=geo.gettoptracks&api_key=c1572082105bd40d247836b5c1819623&format=json&country=netherlands" response, err := http.get(url) if err != nil { fmt.printf("%s\n", err) os.exit(1) } de...
Read more