Noobish JavaScript Nested If-Else Statement Help/Advice/Pointers/YouNameIt -

-

i started learning javascript (today actually) , i'd appreciate nested if-else statements. thought i'd write simple program practice, , seems every if-else statement in if blocks executes regardless of parameter put in. pointers or things notice aren't germane problem @ hand appreciated. again. code below.

edit: i've gotten now, , learned error of ways. commented , gave advice quickly. 

var playerone = prompt('choose rock, paper, or scissors');  var playertwo = prompt('choose rock, paper, or scissors');   var fight = function (playerone, playertwo) {      if( playerone == 'rock' || 'rock')     {          if (playertwo == 'paper' || 'paper')         {             alert('player 2 wins!');         }         else if (playertwo == 'rock' || 'rock')         {             alert('tie!');         }         else         {             alert('player 1 wins!');         }     }          if(playerone == 'paper' || 'paper')         {              if (playertwo == 'paper' || 'paper')             {                 alert('tie!');             }             else if (playertwo == 'rock' || 'rock')             {                 alert('player 1 wins!');              }             else              {                 alert('player 2  wins!');             }         }          if (playerone == 'scissors' || 'scissors')         {              if (playertwo == 'paper' || 'paper')              {                 alert('player 1 wins!');              }             else if (playertwo == 'rock' || 'rock')             {                 alert('player 2 wins!');             }             else             {                 alert('tie!');             }         }  };  fight(playerone, playertwo);

as several people have pointed out, if statements need in form of:

if (playerone == 'paper' || playerone == 'paper')

or more succinct:

if (playerone.tolowercase() == 'paper')

the problem playerone == 'paper' || 'paper' return "truthy" value (see http://11heavens.com/falsy-and-truthy-in-javascript more detail on truthy , falsy values).

as aside, while there's absolutely nothing wrong multiple if statements, if coding exercise way involve less if statements (and little this:

var playerone = prompt('choose rock, paper, or scissors'); var playertwo = prompt('choose rock, paper, or scissors'); var fists = {     "rock": {         "beats": "scissors",         "loses": "paper"     },     "paper": {         "beats": "rock",         "loses": "scissors"     },     "scissors": {         "beats": "paper",         "loses": "rock"     } }  var fight = function (playerone, playertwo) {     playerone = playerone.tolowercase();     playertwo = playertwo.tolowercase();      if (fists[playerone] === undefined || fists[playertwo] === undefined) {         alert('someone threw unknown fist!');     } else if (fists[playerone].beats === playertwo) {         alert('player 1 wins!');     } else if (fists[playertwo].beats === playerone) {         alert('player 2 wins!');     } else {         alert('tie!');     } };  fight(playerone, playertwo);

by objectifying rock/paper/scissors combinations, code imo easier read.


Comments

Post a Comment

Popular posts from this blog

ios - Memory not freeing up after popping viewcontroller using ARC -

-
hi project arc based, using uinavigationcontroller make transition between viewcontroller. using profiler analyse happening behind scene memory. noticed when push viewcontroller allocate memory components , when pop not freeing allocated memory. since using arc unable implement dealloc or release component. have analysed in detail , there no memory leak in project. i not using strong property push viewcontroller. here how pushing viewcontroller. viewcontroller *obj = [[viewcontroller alloc] init]; [self.navigationcontroller pushviewcontroller:obj animated:no]; any clue whats going on? should free memory have consumed. please advise your description indicates have retain cycle, leads objects not being deallocated. typical source of retain cycles properties assigned loading nib files (usually declared iboutlet ). two strategies break them , release objects: declare property weak : @property (nonatomic, weak) iboutlet uilabel *statuslabel; set property nil in...
Read more

Django REST Framework perform_create: You cannot call `.save()` after accessing `serializer.data` -

-
i have following viewset: class artistprofileviewset(viewsets.modelviewset): queryset = artistprofile.objects.all() serializer_class = artistprofileserializer def perform_create(self, serializer): if serializer.is_valid(): serializer.save() with following serializers: class simpleartisttrackserializer(serializers.hyperlinkedmodelserializer): class meta: model = artisttrack fields = (...my fields...) class artistprofileserializer(serializers.hyperlinkedmodelserializer): owners = userserializer(many=true, required=false) tracks = simpleartisttrackserializer(many=true, required=false) class meta: model = artistprofile fields = (...my fields...) i getting following error: assertionerror: cannot call `.save()` after accessing `serializer.data`.if need access data before committing database inspect 'serializer.validated_data' instead. i don't see editing serializer.data object. th...
Read more

Why does Go error when trying to marshal this JSON? -

-
i'm trying rather simple example of trying decode json file structs using golang. however, when attempting error that json: cannot unmarshal object go value of type []main.track which don't understand. here's code in question, , json can found here . package main import ( "encoding/json" "fmt" "net/http" "os" ) // tracks group of track types type tracks struct { tracks []track } // track represents singular track type track struct { name string url string artist artist } // artist represents single artist type artist struct { name string mbid string url string } func main() { url := "http://ws.audioscrobbler.com/2.0/?method=geo.gettoptracks&api_key=c1572082105bd40d247836b5c1819623&format=json&country=netherlands" response, err := http.get(url) if err != nil { fmt.printf("%s\n", err) os.exit(1) } de...
Read more