c++ - Trying to compute my own Histogram without opencv calcHist() -

-

what i'm trying writing function calculates histogram of greyscale image forwarded number of bins (anzbin) histograms range divided in. i'm running through image pixels compairing value different bins , in case value fits, increasing value of bin 1

   vector<int> calcuhisto(const iplimage *src_pic, int anzbin)     {    cvsize size = cvgetsize(src_pic);    int binsize = (size.width / 256)*anzbin;    vector<int> histogram(anzbin,0);      (int y = 0; y<size.height; y++)      {          const uchar *src_pic_point =         (uchar *)(src_pic->imagedata + y*src_pic->widthstep);        (int x = 0; x<size.width; x++)         {         (int z = 0; z < anzbin; z++)         {             if (src_pic_point[x] <= z*binsize)             {                 histogram[src_pic_point[x]]++;             }          }      } } return histogram; }

but unfortunately it's not working... wrong here? please help

there few issues can see

  1. your binsize calculation wrong
  2. your binning algorithm 1 sided, , should 2 sided
  3. you aren't incrementing proper bin when find match

1. binsize calculation

bin size = range / number of bins

2. 2 sided binning

if (src_pic_point[x] <= z*binsize)

you need 2 sided range of values, not 1 sided inequality. imagine have 4 bins , values 0 255. bins should have following ranges 

bin     low     high 0       0       63.75 1       63.75   127.5 2       127.5   191.25 3       191.25  255

for example: value of 57 should go in bin 0. code says value goes in bins! because <= z*binsize need something lower , upper bound.

3. incrementing appropriate bin

you using z loop on each bin, when find match should increment bin z, don't use actual pixel value except when determining bin belongs to

this buffer overrun imagine again have 4 bins, , current pixel has value of 57. code says increment bin 57. have 4 bins (0-3)

histogram[src_pic_point[x]]++;

you want increment bin pixel value falls 

histogram[z]++;

code
in mind here revised code (it untested, should work)

vector<int> calcuhisto(const iplimage *src_pic, int anzbin)  {     cvsize size = cvgetsize(src_pic);     double binsize = 256.0 / anzbin;        //new definition     vector<int> histogram(anzbin,0);        //i don't know if works                                             //so leave      //goes through rows     (int y = 0; y<size.height; y++)      {         //grabs entire row of imagedata         const uchar *src_pic_point = (uchar *)(src_pic->imagedata + y*src_pic->widthstep);          //goes through each column         (int x = 0; x<size.width; x++)          {             //for each bin             (int z = 0; z < anzbin; z++)             {                 //check both upper , lower limits                 if (src_pic_point[x] >= z*binsize && src_pic_point[x] < (z+1)*binsize)                 {                     //increment index contains point                     histogram[z]++;                 }             }         }     }     return histogram; }

Comments

Post a Comment

Popular posts from this blog

ios - Memory not freeing up after popping viewcontroller using ARC -

-
hi project arc based, using uinavigationcontroller make transition between viewcontroller. using profiler analyse happening behind scene memory. noticed when push viewcontroller allocate memory components , when pop not freeing allocated memory. since using arc unable implement dealloc or release component. have analysed in detail , there no memory leak in project. i not using strong property push viewcontroller. here how pushing viewcontroller. viewcontroller *obj = [[viewcontroller alloc] init]; [self.navigationcontroller pushviewcontroller:obj animated:no]; any clue whats going on? should free memory have consumed. please advise your description indicates have retain cycle, leads objects not being deallocated. typical source of retain cycles properties assigned loading nib files (usually declared iboutlet ). two strategies break them , release objects: declare property weak : @property (nonatomic, weak) iboutlet uilabel *statuslabel; set property nil in...
Read more

Django REST Framework perform_create: You cannot call `.save()` after accessing `serializer.data` -

-
i have following viewset: class artistprofileviewset(viewsets.modelviewset): queryset = artistprofile.objects.all() serializer_class = artistprofileserializer def perform_create(self, serializer): if serializer.is_valid(): serializer.save() with following serializers: class simpleartisttrackserializer(serializers.hyperlinkedmodelserializer): class meta: model = artisttrack fields = (...my fields...) class artistprofileserializer(serializers.hyperlinkedmodelserializer): owners = userserializer(many=true, required=false) tracks = simpleartisttrackserializer(many=true, required=false) class meta: model = artistprofile fields = (...my fields...) i getting following error: assertionerror: cannot call `.save()` after accessing `serializer.data`.if need access data before committing database inspect 'serializer.validated_data' instead. i don't see editing serializer.data object. th...
Read more

Why does Go error when trying to marshal this JSON? -

-
i'm trying rather simple example of trying decode json file structs using golang. however, when attempting error that json: cannot unmarshal object go value of type []main.track which don't understand. here's code in question, , json can found here . package main import ( "encoding/json" "fmt" "net/http" "os" ) // tracks group of track types type tracks struct { tracks []track } // track represents singular track type track struct { name string url string artist artist } // artist represents single artist type artist struct { name string mbid string url string } func main() { url := "http://ws.audioscrobbler.com/2.0/?method=geo.gettoptracks&api_key=c1572082105bd40d247836b5c1819623&format=json&country=netherlands" response, err := http.get(url) if err != nil { fmt.printf("%s\n", err) os.exit(1) } de...
Read more